refactor: uses built-in express validator functions instead of custom#2297
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors validation logic by replacing custom regular expression validators with built-in express-validator functions for better maintainability and reliability.
- Replaced custom regex patterns for IPv4, IPv6, and FQDN validation with express-validator's built-in methods
- Simplified port validation using the built-in
isPort()validator - Restructured validation logic to use conditional validation chains instead of a custom function
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
rsdmike
force-pushed
the
refactorValidator
branch
from
August 26, 2025 22:14
5ea75c9 to
5128978
Compare
graikhel-intel
previously approved these changes
Aug 26, 2025
jaolanlo
reviewed
Aug 26, 2025
rsdmike
force-pushed
the
refactorValidator
branch
from
August 26, 2025 22:55
5128978 to
d6db74d
Compare
rsdmike
enabled auto-merge (rebase)
August 26, 2025 23:00
graikhel-intel
approved these changes
Aug 27, 2025
|
🎉 This PR is included in version 2.28.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What are you changing?
Anything the reviewer should know when reviewing this PR?
If the there are associated PRs in other repositories, please link them here (i.e. device-management-toolkit/repo#365 )